Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firewall Policy resources for the Azure Firewall resources deployed by the module #274

Closed
krowlandson opened this issue Feb 17, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@krowlandson
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is your feature request related to a problem?

No

Describe the solution you'd like

As documented, Azure Firewall supports both Classic rules and policies, but policies is the recommenced configuration.

The native ARM implementation already deploys a Microsoft.Network/firewallPolicies resource and links it to each Microsoft.Network/azureFirewalls resource created by the deployment.

As the recommendation is to use firewall policies, we want to update the module to natively support creation and attachment of a firewall policy for each Azure Firewall deployed by the module.

Currently customers can attach their own policy using the advanced {} configuration within the configure_connectivity_resources input variable (and we will ensure customer-specified configurations continue to take precedence over module defaults), but we would like to implement a default firewall policy which customers can then attach rule sets to, or use policy rule hierarchies to customise.

Additional context

@krowlandson krowlandson added the enhancement New feature or request label Feb 17, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 17, 2022
@matt-FFFFFF matt-FFFFFF removed the Needs: Triage 🔍 Needs triaging by the team label Mar 4, 2022
@krowlandson krowlandson self-assigned this Apr 26, 2022
@krowlandson
Copy link
Contributor Author

Fixed by #331

@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants