-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify a private_dns_zone_id #139
base: main
Are you sure you want to change the base?
Conversation
it looks good to me - i initially misread and thought the RBAC was in the module, but I see it is in the example my bad. I think it is important modules support ALZs. After all, beautifully crafted LZs with all the policies and CAF practices is what we should be deploying into (oh look, there goes a unicorn 😸). edit - a minor point - I think the variable should set Good to see this being incorporated. 🚀 |
Description
Fixes #136
Closes #136