Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a private_dns_zone_id #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow to specify a private_dns_zone_id #139

wants to merge 1 commit into from

Conversation

zioproto
Copy link
Collaborator

Description

Fixes #136
Closes #136

@kewalaka
Copy link

kewalaka commented Nov 16, 2024

it looks good to me - i initially misread and thought the RBAC was in the module, but I see it is in the example my bad.

I think it is important modules support ALZs. After all, beautifully crafted LZs with all the policies and CAF practices is what we should be deploying into (oh look, there goes a unicorn 😸).

edit - a minor point - I think the variable should set nullable = false - it'll either be system or the resource ID, if I'm understanding correctly?

Good to see this being incorporated. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Missing private_dns_zone_id resource definition
3 participants