Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warm/fast reboot] some service docker might have been stopped already #668

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Sep 24, 2019

- What I did

Some services are depending on swss and might have been stopped at the
time the loop of docker killing was executed.

Signed-off-by: Ying Xie [email protected]

- How to verify it
Without the change, continuous fast-reboot seems to hit the issue fairly frequently where snmp docker has been stopped when reaching the docker kill loop. And that would cause test to fail.

With the fix, the snmp docker could still be killed already, but test would continue.

Some services are depending on swss and might have been stopped at the
time the loop of docker killing was executed.

Signed-off-by: Ying Xie <[email protected]>
@yxieca
Copy link
Contributor Author

yxieca commented Sep 24, 2019

retest this please

scripts/fast-reboot Outdated Show resolved Hide resolved
scripts/fast-reboot Outdated Show resolved Hide resolved
@yxieca
Copy link
Contributor Author

yxieca commented Sep 25, 2019

retest this please

@yxieca yxieca merged commit bf79c95 into sonic-net:master Sep 25, 2019
@yxieca yxieca deleted the warmboot branch September 25, 2019 18:39
yxieca added a commit that referenced this pull request Sep 25, 2019
#668)

* [warm/fast reboot] some service docker might have been stopped already

Some services are depending on swss and might have been stopped at the
time the loop of docker killing was executed.

Signed-off-by: Ying Xie <[email protected]>

* log and ignore all errors while killing containers

* add debug message

* put redirect at the right place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants