[202012] [generate_dump] allow to extend dump with plugin scripts #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
approved these changes
Jul 18, 2022
|
@qiluo-msft can you please help to review? |
liat-grozovik
approved these changes
Jul 18, 2022
noaOrMlnx
added a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Jul 20, 2022
Update sonic-utilities submodule pointer to include the following: * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([sonic-net#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([sonic-net#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: noaOrMlnx <[email protected]>
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jul 21, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test for pfcwd_sw_enable in db_migrator_test ([sonic-net#2252](sonic-net/sonic-utilities#2252)) * [DHCPv6] [202012] Update the dhcpv6_relay config/show cli ([sonic-net#2271](sonic-net/sonic-utilities#2271)) * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([sonic-net#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([sonic-net#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: dprital <[email protected]>
7 tasks
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 29, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test for pfcwd_sw_enable in db_migrator_test ([#2252](sonic-net/sonic-utilities#2252)) * [DHCPv6] [202012] Update the dhcpv6_relay config/show cli ([#2271](sonic-net/sonic-utilities#2271)) * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: dprital <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Noa Or [email protected]
What I did
Added support for tech support extension scripts,
by cherry-picking of #1335 to 202012 branch.
The purpose is to have dumps of extensions in SONiC techsupport, even without App Extension infrastructure.
The new application will write a file that contains the dump command into /usr/bin/debug-dump folder, and it will appear in the output of
show techsupportcommand.How I did it
It looks at /usr/bin/debug-dump for scripts, if it finds one it will execute them and save the output to dump/ folder.
How to verify it
Write a simple scripts with an output and place it under /usr/bin/debug-dump/
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)