[GCU] Using simulated config instead of target config when validating replace operation in NoDependencyMoveValidator #1987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Using
SimulatedConfig
instead ofTargetConfig
for validating a move usingNoDependencyMoveValidator
SimulatedConfig: config after applying the given move
TargetConfig: the final config state that's required by the patch
The problem is if the moves is to update a list item, the list item location in the
TargetConfig
might have different location in theCurrentConfig
.The reason for that is the
TargetConfig
has the final outcome after applying thepatch
, but the move might be just making a small change towards this goal.Example:
Assume current_config
TargetConfig:
Move:
The move means:
Notice how the array index in CurrentConfig does not exist in TargetConfig
Instead of using TargetConfig to validate, use SimulatedConfig which is the config after applying the move. In this case it would be:
How I did it
Replace
diff.target_config
withsimulated_config
How to verify it
added a unit-test