generic_updater: Fix service validator related issues #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
previously approved these changes
Oct 28, 2021
2) Read conf file from install dir 3) Drop empty keys & tables upon jsonpatch.JsonPatch.apply to be in sync with redis update 4) Prefix service_validator module path with "generic_updater"
renukamanavalan
changed the title
ghooo
approved these changes
Nov 4, 2021
qiluo-msft
reviewed
Nov 9, 2021
| @@ -8,8 +8,8 @@ | |||
| from swsscommon.swsscommon import ConfigDBConnector | |||
| from .gu_common import genericUpdaterLogging | |||
|
|
|||
|
|
|||
| UPDATER_CONF_FILE = "/etc/sonic/generic_config_updater.conf" | |||
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
ce8b1af9d2200c570c102a38e04cbd9659470585 (HEAD -> 201911, origin/201911) const initializer_list is not a constant expression (sonic-net#1250) acdb03324fc268f5330d2632a02d0856f35fb880 [201911] Add lgtm.yml (sonic-net#1901) Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
For updates on tables configured with services, the service code is invoked, as expected.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)