Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic_upater: Apply JSON change #1856

Merged
merged 11 commits into from
Oct 25, 2021

Conversation

renukamanavalan
Copy link
Contributor

What I did

Apply JSON change

How I did it

Get running config, apply json change and set the updates onto running redis.

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2021

This pull request introduces 1 alert when merging 84f493b into bed8f72 - view on LGTM.com

new alerts:

  • 1 for Unused import

@renukamanavalan renukamanavalan requested a review from ghooo October 7, 2021 00:01
@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 5 alerts when merging 6e0bba0 into 112b44e - view on LGTM.com

new alerts:

  • 2 for First parameter of a method is not named 'self'
  • 2 for Unused import
  • 1 for Testing equality to None

@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2021

This pull request introduces 4 alerts when merging bd7781c into e600e1c - view on LGTM.com

new alerts:

  • 2 for First parameter of a method is not named 'self'
  • 1 for Testing equality to None
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 1 alert when merging f839e53 into 6595ad4 - view on LGTM.com

new alerts:

  • 1 for Unused import

@qiluo-msft qiluo-msft requested a review from wen587 October 21, 2021 03:13
@renukamanavalan renukamanavalan merged commit 0b2536b into sonic-net:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants