-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[show][techsupport][multi-ASIC] Add support to collect tech support on multi ASIC platform #1193
Conversation
@abdosi Can you check if any of the commands need to be run on all namespaces. I see 'lldpctl', it doesn't seem to have the option of running on all namespaces. 'sudo ip netns .... ' gives the same output. |
🔔 |
retest this please |
1 similar comment
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Suggest also ask @jleveque to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to submit comment so they remain in pending state.
############################################################################### | ||
collect_broadcom() { | ||
save_cmd "bcmcmd -t5 version" "broadcom.version" | ||
save_cmd "bcmcmd -t5 soc" "broadcom.soc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to get this for each asic ? bcmcmd -n <asic_instance>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smaheshm any update on this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can add this in my next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smaheshm can we fix this before taking in 201911 and this change for multi-asic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its coming in #1249
- What I did
Add support to collect tech support on multi ASIC platform
Refactored code to put together related commands in a function.
- How I did it
Modified generate_dump script to run relevant commands on all namespaces for multi ASIC platform. On single ASIC the commands are run in default (host) namesapce.
- How to verify it
Manual verification, and pytest.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)