Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portsorch]: add support to set mac-address learning attribute on bridge-port #809

Merged
merged 11 commits into from
Nov 12, 2019

Conversation

shine4chen
Copy link
Contributor

What I did
add support to set mac-address learning attribute on bridge-port

Why I did it
Mclag feature need this. And it is common attribute for bridge-port.

How I verified it
compile and test on nephos lab

Details if related

@shine4chen shine4chen changed the title add support to set mac-address learning attribute on bridge-port [portsorch]: add support to set mac-address learning attribute on bridge-port Mar 11, 2019
@lguohan
Copy link
Contributor

lguohan commented Apr 25, 2019

learning mode can also be supported in lag, but it looks like the code here does not consider that scenario.

@jianjundong
Copy link

learning mode can also be supported in lag, but it looks like the code here does not consider that scenario.

Lag is also supported, please see the function PortsOrch::doLagTask(Consumer &consumer). Thinks.

@leoli-nps
Copy link
Contributor

Learning mode has been supported in lag, but the corresponding vs-test requires lag-name-oid-map. PR#885 will provide support for lag-name-oid-map, so the vs-test code can only be provided after its modification is completed.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add vstest

stcheng
stcheng previously requested changes Jun 4, 2019
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add unit tests. thanks!

orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
@leoli-nps
Copy link
Contributor

The vstest has been added, please review. Thanks!

@shine4chen
Copy link
Contributor Author

shine4chen commented Jun 17, 2019

@stcheng we has refined code according to your suggestion. Pls review thanks.

Copy link

@lisahnguyen lisahnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shine4chen: thanks for addressing my review comment.

Copy link
Contributor

@gitsabari gitsabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of review comments

@shine4chen
Copy link
Contributor Author

retest this please

@shine4chen shine4chen force-pushed the bridge-port-mac-learn branch 2 times, most recently from 32416e3 to 53a3f1e Compare October 4, 2019 02:47
@lguohan lguohan dismissed stcheng’s stale review November 12, 2019 16:31

comments has been addressed

@lguohan lguohan merged commit 190373a into sonic-net:master Nov 12, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Introduce `gbsyncdmgrd`, which will be responsible for spawning and watching all gearbox syncd processes.

`gbsyncdmgrd` is intended to supplant `gbsyncd_startup.py`. But until all references have been updated, we keep both, and I have added a deprecation warning to `gbsyncd_startup.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants