-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. #2277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try add VS tests.
host_tx_ready_UT.txt |
May you please explain 'VS tests' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The description seems to suggest that if admin is UP then host_tx_ready = true, which is not the case. Can we rephrase? |
can you add unit test here:- https://github.com/Azure/sonic-swss/tree/master/tests
|
@prsunny , I understood that it requires a ubuntu machine to setup the environment to run the VS test code. I am working with IT team to setup the environment. |
@liat-grozovik @keboliu can you please review this PR? |
@prgeor to signoff/merge |
3d44c37
to
357b335
Compare
@jaganbal-a please update this section in the description
|
@jaganbal-a VS test failure is due to this issue |
Unit test log |
@jaganbal-a please rebase your changes with latest swss |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jaganbal-a can you rebase once again? |
orchagent changes for sonic-net/SONiC#916
Addressing PR comment
Addressing PR comments-cosmetic
VS test code and addressing PR comment
set host_tx_ready to false if gbsyncd SAI API fails.
…h before enabling transceiver<CMIS compliant> Tx. (#2277) * Signed-off-by: Jaganathan Anbalagan <[email protected]> orchagent changes for sonic-net/SONiC#916 * Signed-off-by: Jaganathan Anbalagan <[email protected]> Addressing PR comment * Signed-off-by: Jaganathan Anbalagan <[email protected]> Addressing PR comments-cosmetic * Signed-off-by: Jaganathan Anbalagan <[email protected]> fixed typo * Signed-off-by: Jaganathan Anbalagan <[email protected]> VS test code and addressing PR comment * Signed-off-by: Jaganathan Anbalagan <[email protected]> set host_tx_ready to false if gbsyncd SAI API fails. Co-authored-by: Jaganathan Anbalagan <[email protected]>
…h before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) * Signed-off-by: Jaganathan Anbalagan <[email protected]> orchagent changes for sonic-net/SONiC#916 * Signed-off-by: Jaganathan Anbalagan <[email protected]> Addressing PR comment * Signed-off-by: Jaganathan Anbalagan <[email protected]> Addressing PR comments-cosmetic * Signed-off-by: Jaganathan Anbalagan <[email protected]> fixed typo * Signed-off-by: Jaganathan Anbalagan <[email protected]> VS test code and addressing PR comment * Signed-off-by: Jaganathan Anbalagan <[email protected]> set host_tx_ready to false if gbsyncd SAI API fails. Co-authored-by: Jaganathan Anbalagan <[email protected]>
What I did
Orchagent changes for sonic-net/SONiC#916
Why I did it
xcvrd will be handling "host_tx_ready" change of value event for CMIS complaint modules to bring it to appropriate CMIS state on the CMIS complaint modules.
How I verified it
UT logs attached.
Details if related