[restore_neighbors] python3 support for restore_neighbors.py #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 15, 2020
…restore_neighbors.py (#6207) Install the necessary python3 dependent packages to convert restore_neighbor.py to support python3 as python2 is EOL. See: sonic-net/sonic-swss#1542 Signed-off-by: Zhenggen Xu <[email protected]>
|
I believe the vs test will fail until the next vs image is built later today with the changes from sonic-net/sonic-buildimage#6207. Will wait to retest until tomorrow. |
|
retest this please |
3 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
Signed-off-by: Zhenggen Xu <[email protected]>
zhenggen-xu
force-pushed
the
python3-neighbor-restore
branch
from
f666c7a
to
a20dd85
Compare
|
retest vs please |
|
retest this please |
1 similar comment
|
retest this please |
lguohan
approved these changes
Dec 20, 2020
3 tasks
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
bug introduced in sonic-net#1393 Signed-off-by: Guohan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[restore_neighbors] python3 support for restore_neighbors.py
Signed-off-by: Zhenggen Xu [email protected]
This is dependent on sonic-net/sonic-buildimage#6207
What I did
Change the restore_neighbors.py to support python3
Why I did it
python2 EOL.
How I verified it
swss vs tests
Details if related