[sonic_fan]Add constant for fan direction #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2020
keboliu
approved these changes
Jan 19, 2020
liat-grozovik
approved these changes
Jan 21, 2020
|
@jleveque can you please review? |
jleveque
approved these changes
Jan 22, 2020
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…ic-net#78) Merge of QSFP-DD support via PR# sonic-net#66 is making xcvrd to bail out on platforms that do not support new key/attribute. Fix is to ignore new key/attribute if not present/supported yet. Fix takes changes done as part of PR#sonic-net#76 which can be closed once this gets merged Verified manually xcvrd running fine after above changes. also command show interface transceiver is showing correct o/p Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add string constants for fan directions
- How I did it