[pytest/hash] Rewrite hash test #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lguohan
reviewed
Apr 1, 2020
lguohan
reviewed
Apr 1, 2020
lguohan
reviewed
Apr 1, 2020
lguohan
reviewed
Apr 1, 2020
lguohan
reviewed
Apr 1, 2020
lguohan
reviewed
Apr 1, 2020
|
i am ok with the rewrite, but have some minor comments, can you address them? |
|
I will review other PR once this one is done. |
All modifications have been completed. |
lguohan
approved these changes
Apr 3, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Made the following change:
Rewrite hash test. Test hash keys defined in test_fib.py instead of hash_test.py.
Sub PR of Enhance hash test #1494
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation