Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang]: Update AAA yang models #9724

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Jan 11, 2022

Signed-off-by: Gang Lv [email protected]

Why I did it

AAA yang model is not up to date.

How I did it

Add fallback and trace field, and replace boolean_type

How to verify it

Run UT for sonic_yang_models.
Follow the steps from #9710

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

Fix #9710

A picture of a cute animal (not mandatory but encouraged)

@ganglyu ganglyu added the YANG YANG model related changes label Jan 11, 2022
@wen587
Copy link
Contributor

wen587 commented Jan 11, 2022

Verified from local mannually test. It works.

admin@vlab-01:~/tacacs$ sudo config apply-patch -i /FEATURE -i /QUEUE -i /SCHEDULER t1.json
Patch Applier: Patch application starting.
Patch Applier: Patch: [{"op": "add", "path": "/AAA", "value": {"authentication": {"debug": "True", "failthrough": "True", "fallback": "True", "login": "local,tacacs+", "trace": "True"}}}]
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
...
Patch Applier: The patch was sorted into 5 changes:
Patch Applier:   * [{"op": "add", "path": "/AAA", "value": {"authentication": {"debug": "True"}}}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/failthrough", "value": "True"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/fallback", "value": "True"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/login", "value": "local,tacacs+"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/trace", "value": "True"}]
Patch Applier: Applying 5 changes in order:
Patch Applier:   * [{"op": "add", "path": "/AAA", "value": {"authentication": {"debug": "True"}}}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/failthrough", "value": "True"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/fallback", "value": "True"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/login", "value": "local,tacacs+"}]
Patch Applier:   * [{"op": "add", "path": "/AAA/authentication/trace", "value": "True"}]
Patch Applier: Verifying patch updates are reflected on ConfigDB.
Patch Applier: Patch application completed.
Patch applied successfully.

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait some days for more eyes.

@qiluo-msft qiluo-msft merged commit c69d376 into sonic-net:master Jan 12, 2022
@ganglyu ganglyu added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 20, 2022
judyjoseph pushed a commit that referenced this pull request Jan 23, 2022
#### Why I did it
AAA yang model is not up to date.

#### How I did it
Add fallback and trace field, and replace boolean_type

#### How to verify it
Run UT for sonic_yang_models.
Follow the steps from #9710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yang-models] sonic-system-aaa.yang missing key in aaa authentication
5 participants