Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sflow][port_index_mapper.py] Convert to Python 3; Use logger from sonic-py-common for uniform logging #5791

Closed
wants to merge 1 commit into from

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Nov 3, 2020

- Why I did it

As part of moving all SONiC code from Python 2 (no longer supported) to Python 3

- How I did it

  • Convert port_index_mapper.py script to Python 3
  • Use logger from sonic-py-common for uniform logging
  • Reorganize imports alphabetically per PEP8 standard
  • Two blank lines precede functions per PEP8 standard

- How to verify it

Ensure port_index_mapper.py still functions correctly

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

@jleveque
Copy link
Contributor Author

jleveque commented Nov 5, 2020

Closing in favor of #5800, which fixes bugs and now also converts to Python 3

@jleveque jleveque closed this Nov 5, 2020
@jleveque jleveque deleted the port_index_mapper_py3 branch November 5, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant