[services] introduce sonic.target #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 45cb06505f6a docker-sonic-telemetry:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes telemetry afb299c49d4c docker-snmp:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes snmp 5c75d20d71cf docker-sonic-mgmt-framework:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes mgmt-framework 3e0563cd556f docker-router-advertiser:latest "/usr/bin/docker-ini…" About an hour ago Up 12 minutes radv 65f94b300db1 docker-platform-monitor:latest "/usr/bin/docker_ini…" About an hour ago Up About a minute pmon 4ffadb5817aa docker-dhcp-relay:latest "/usr/bin/docker_ini…" About an hour ago Up 12 minutes dhcp_relay 65058396277c docker-lldp:latest "/usr/bin/docker-lld…" About an hour ago Up 12 minutes lldp f922b7a26b06 docker-syncd-mlnx:latest "/usr/bin/supervisord" About an hour ago Up 12 minutes syncd 4f3aaddcacf9 docker-teamd:latest "/usr/bin/supervisord" About an hour ago Up 13 minutes teamd c3622c5322b2 docker-orchagent:latest "/usr/bin/docker-ini…" About an hour ago Up 13 minutes swss 370acc8b2289 docker-fpm-frr:latest "/usr/bin/docker_ini…" About an hour ago Up 13 minutes bgp 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 13 minutes database admin@r-tigon-11:~$ sudo systemctl stop sonic.target admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 14 minutes database admin@r-tigon-11:~$ sudo systemctl restart sonic.target admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 45cb06505f6a docker-sonic-telemetry:latest "/usr/bin/supervisord" About an hour ago Up 11 seconds telemetry afb299c49d4c docker-snmp:latest "/usr/bin/supervisord" About an hour ago Up 6 seconds snmp 5c75d20d71cf docker-sonic-mgmt-framework:latest "/usr/bin/supervisord" About an hour ago Up 8 seconds mgmt-framework 3e0563cd556f docker-router-advertiser:latest "/usr/bin/docker-ini…" About an hour ago Up 16 seconds radv 65f94b300db1 docker-platform-monitor:latest "/usr/bin/docker_ini…" About an hour ago Up 17 seconds pmon 4ffadb5817aa docker-dhcp-relay:latest "/usr/bin/docker_ini…" About an hour ago Up 17 seconds dhcp_relay 65058396277c docker-lldp:latest "/usr/bin/docker-lld…" About an hour ago Up 17 seconds lldp f922b7a26b06 docker-syncd-mlnx:latest "/usr/bin/supervisord" About an hour ago Up 18 seconds syncd 4f3aaddcacf9 docker-teamd:latest "/usr/bin/supervisord" About an hour ago Up About a minute teamd c3622c5322b2 docker-orchagent:latest "/usr/bin/docker-ini…" About an hour ago Up About a minute swss 370acc8b2289 docker-fpm-frr:latest "/usr/bin/docker_ini…" About an hour ago Up About a minute bgp 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 17 minutes database Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
requested review from
jleveque,
yxieca,
lguohan and
renukamanavalan
|
What is the behavior if we issue systemctl start sonic.target when it is already started? Particularly, will it restart all 'wanted' services? What if the downstream service is started? What if downstream service is a oneshot timer which will start another service? |
|
@yxieca normal services are not touched, one-shot and timers get started, so delayed services restart as well as one-shot services. |
|
You may also want to apply these changes to this service file: https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-host-services-data/debian/sonic-host-services-data.procdockerstatsd.service |
'Conficts=' in timer units caused a problem when starting a timer causes restart of a service. Instead, 'PartOf=' is a better choice. 'PartOf=' will make the timer stop and restart togather with the service the timer is bound to, otherwise the timer OnUnitActiveSec expires imidiatelly when the service stops and starts it. Signed-off-by: Stepan Blyshchak <[email protected]>
To prevent restarts on 'systemctl start <service>'. Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 45cb06505f6a docker-sonic-telemetry:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes telemetry afb299c49d4c docker-snmp:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes snmp 5c75d20d71cf docker-sonic-mgmt-framework:latest "/usr/bin/supervisord" About an hour ago Up 9 minutes mgmt-framework 3e0563cd556f docker-router-advertiser:latest "/usr/bin/docker-ini…" About an hour ago Up 12 minutes radv 65f94b300db1 docker-platform-monitor:latest "/usr/bin/docker_ini…" About an hour ago Up About a minute pmon 4ffadb5817aa docker-dhcp-relay:latest "/usr/bin/docker_ini…" About an hour ago Up 12 minutes dhcp_relay 65058396277c docker-lldp:latest "/usr/bin/docker-lld…" About an hour ago Up 12 minutes lldp f922b7a26b06 docker-syncd-mlnx:latest "/usr/bin/supervisord" About an hour ago Up 12 minutes syncd 4f3aaddcacf9 docker-teamd:latest "/usr/bin/supervisord" About an hour ago Up 13 minutes teamd c3622c5322b2 docker-orchagent:latest "/usr/bin/docker-ini…" About an hour ago Up 13 minutes swss 370acc8b2289 docker-fpm-frr:latest "/usr/bin/docker_ini…" About an hour ago Up 13 minutes bgp 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 13 minutes database admin@r-tigon-11:~$ sudo systemctl stop sonic.target admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 14 minutes database admin@r-tigon-11:~$ sudo systemctl restart sonic.target admin@r-tigon-11:~$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 45cb06505f6a docker-sonic-telemetry:latest "/usr/bin/supervisord" About an hour ago Up 11 seconds telemetry afb299c49d4c docker-snmp:latest "/usr/bin/supervisord" About an hour ago Up 6 seconds snmp 5c75d20d71cf docker-sonic-mgmt-framework:latest "/usr/bin/supervisord" About an hour ago Up 8 seconds mgmt-framework 3e0563cd556f docker-router-advertiser:latest "/usr/bin/docker-ini…" About an hour ago Up 16 seconds radv 65f94b300db1 docker-platform-monitor:latest "/usr/bin/docker_ini…" About an hour ago Up 17 seconds pmon 4ffadb5817aa docker-dhcp-relay:latest "/usr/bin/docker_ini…" About an hour ago Up 17 seconds dhcp_relay 65058396277c docker-lldp:latest "/usr/bin/docker-lld…" About an hour ago Up 17 seconds lldp f922b7a26b06 docker-syncd-mlnx:latest "/usr/bin/supervisord" About an hour ago Up 18 seconds syncd 4f3aaddcacf9 docker-teamd:latest "/usr/bin/supervisord" About an hour ago Up About a minute teamd c3622c5322b2 docker-orchagent:latest "/usr/bin/docker-ini…" About an hour ago Up About a minute swss 370acc8b2289 docker-fpm-frr:latest "/usr/bin/docker_ini…" About an hour ago Up About a minute bgp 16f359ad4057 docker-database:latest "/usr/local/bin/dock…" About an hour ago Up 17 minutes database Signed-off-by: Stepan Blyschak <[email protected]>
'Conficts=' in timer units caused a problem when starting a timer causes restart of a service. Instead, 'PartOf=' is a better choice. 'PartOf=' will make the timer stop and restart togather with the service the timer is bound to, otherwise the timer OnUnitActiveSec expires imidiatelly when the service stops and starts it. Signed-off-by: Stepan Blyshchak <[email protected]>
To prevent restarts on 'systemctl start <service>'. Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
yxieca
previously approved these changes
Oct 29, 2020
|
Please fix new conflicts, as hostcfgd has moved. Also please apply necessary changes to the other services in the new sonic-host-services package. |
Signed-off-by: Stepan Blyshchak <[email protected]>
|
@stepanblyschak: Has this been tested thoroughly? |
Signed-off-by: Stepan Blyshchak <[email protected]>
|
This was tested in different scenarios:
However, on recent master this change became broken because of #6115 wich introduced a cycle between ntp-config and ntp service. As a result config reload hangs forever. I am investigating further for a fix. |
|
Retest vsimage please |
rajendra-dendukuri
previously approved these changes
Jan 15, 2021
|
Retest vsimage please |
|
Retest this please |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 5705 in repo Azure/sonic-buildimage |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@stepanblyschak can you resolve conflicts so we can have clean build and move forward with mergint it? this is an enhancement we would like to have in 202012 as well |
…_target Signed-off-by: Stepan Blyshchak <[email protected]>
stepanblyschak
dismissed stale reviews from rajendra-dendukuri and yxieca
via
d0efdf0
|
@rajendra-dendukuri and @yxieca i am sure i saw the approval before but for some reason it is deleted. Can you please add it again? |
@liat-grozovik: Repo settings have changed such that when new commits are pushed to the repo any existing approvals are reset. This prevents unreviewed commits from sneaking in after an approval. |
rajendra-dendukuri
approved these changes
Feb 18, 2021
yxieca
approved these changes
Feb 21, 2021
I also noticed this. Seems that when new change is pushed in. github dismisses old approvals. But this doesn't happen consistently. I also see new changes added and approval sticks. I didn't figure out what was the difference. |
yxieca
pushed a commit
that referenced
this pull request
Mar 4, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <[email protected]>
4 tasks
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <[email protected]>
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
- Why I did it Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services. - How I did it Add services to sonic.target - How to verify it Together with sonic-net/sonic-utilities#1199 config reload -y Signed-off-by: Stepan Blyshchak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
- Why I did it
Group all SONiC services together and able to manage them together. Will be used in config reload command as much simpler and generic way to restart services.
- How I did it
Add services to sonic.target
- How to verify it
Together with sonic-net/sonic-utilities#1199
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)