Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChassisDB]: bring up ChassisDB service #5283

Merged
merged 1 commit into from
Oct 14, 2020
Merged

[ChassisDB]: bring up ChassisDB service #5283

merged 1 commit into from
Oct 14, 2020

Conversation

BrynXu
Copy link
Contributor

@BrynXu BrynXu commented Aug 31, 2020 •
edited
Loading

bring up chassisdb service on sonic switch according to the design in
Distributed Forwarding in VoQ Arch HLD

Signed-off-by: Honggang Xu [email protected]

- Why I did it
To bring up new ChassisDB service in sonic as designed in 'Distributed forwarding in a VOQ architecture HLD' .

- How I did it
Implement the section 2.3.1 Global DB Organization of the VOQ architecture HLD.

- How to verify it
ChassisDB service won't start without chassisdb.conf file on the existing platforms.
ChassisDB service is accessible with global.conf file in the distributed arichitecture.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2020

This pull request introduces 4 alerts when merging 1190623c216643b24691271cad41573fae790fab into 3d6ef3e - view on LGTM.com

new alerts:

  • 4 for Unused import

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 3, 2020

retest braodcom please, retest vsimage please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 4, 2020

retest broadcom please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 4, 2020

retest vsimage please

tahmed-dev
tahmed-dev reviewed Sep 9, 2020
View reviewed changes
src/sonic-config-engine/sonic-cfggen Outdated Show resolved Hide resolved
platform/vs/docker-sonic-vs/start.sh Outdated Show resolved Hide resolved
dockers/docker-database/docker-database-init.sh Outdated Show resolved Hide resolved
files/build_templates/docker_image_ctl.j2 Outdated Show resolved Hide resolved
@BrynXu BrynXu force-pushed the globaldbPR branch 6 times, most recently from 8fc443f to 277f115 Compare September 17, 2020 17:53
@BrynXu BrynXu changed the title [GlobalDB]: bring up GlobalDB service [DB]: bring up GlobalDB service Sep 17, 2020
@BrynXu BrynXu changed the title [DB]: bring up GlobalDB service [ChassisDB]: bring up ChassisDB service Sep 17, 2020
@BrynXu BrynXu force-pushed the globaldbPR branch 6 times, most recently from 9cf388b to 332b869 Compare September 18, 2020 20:42
@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 21, 2020

retest baseimage please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 21, 2020

retest vs please
retest vsimage please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 21, 2020

retest vs please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 22, 2020

retest mellanox please

@BrynXu
Copy link
Contributor Author

BrynXu commented Sep 23, 2020

retest vs please

@BrynXu BrynXu force-pushed the globaldbPR branch 2 times, most recently from 20aa69f to b20e826 Compare September 29, 2020 16:49
lguohan
lguohan previously approved these changes Sep 30, 2020
View reviewed changes
@BrynXu
Copy link
Contributor Author

BrynXu commented Oct 1, 2020

retest vsimage please

@hxu2023
[ChassisDB]: bring up ChassisDB service
19448e5 
bring up chassisdb service on sonic switch according to the design
in Distributed Forwarding in VoQ Arch HLD

Signed-off-by: Honggang Xu <[email protected]>
@lguohan lguohan merged commit a2e3d2f into sonic-net:master Oct 14, 2020
@BrynXu BrynXu mentioned this pull request Oct 18, 2020
Merged
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@BrynXu @santhosh-kt
[ChassisDB]: bring up ChassisDB service (sonic-net#5283)
b99b79d 
bring up chassisdb service on sonic switch according to the design in
Distributed Forwarding in VoQ Arch HLD

Signed-off-by: Honggang Xu <[email protected]>

**- Why I did it**
To bring up new ChassisDB service in sonic as designed in ['Distributed forwarding in a VOQ architecture HLD' ](https://github.com/Azure/SONiC/blob/90c1289eaf89a70939e7c81e042e261947c6a850/doc/chassis/architecture.md). 

**- How I did it**
Implement the section 2.3.1 Global DB Organization of the VOQ architecture HLD.

**- How to verify it**
ChassisDB service won't start without chassisdb.conf file on the existing platforms.
ChassisDB service is accessible with global.conf file in the distributed arichitecture.

Signed-off-by: Honggang Xu <[email protected]>
@judyjoseph judyjoseph mentioned this pull request Dec 10, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlorrillere mlorrillere mlorrillere left review comments

@eswaranb eswaranb eswaranb left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

@tahmed-dev tahmed-dev tahmed-dev left review comments

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BrynXu @mlorrillere @lguohan @eswaranb @qiluo-msft @tahmed-dev @hxu2023