[systemd-generator]: Remove creation of NUM_ASIC environment variable #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variable as it is not being used. Signed-off-by: SuvarnaMeenakshi <[email protected]>
judyjoseph
approved these changes
Aug 7, 2020
lguohan
approved these changes
Aug 7, 2020
abdosi
approved these changes
Aug 7, 2020
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
abdosi
pushed a commit
that referenced
this pull request
Aug 19, 2020
NUM_ASIC environment variable was added so that it could be used by other utilities. This is not being used by any other utility or docker, hence removing the addition of NUM_ASIC environment variable. Also, the environment variable was added by adding the variable value to /etc/environ file. Upon each reboot, this file gets updated with the NUM_ASIC value but the existing value was not removed. This causes multiple lines getting appended in /etc/environ file upon each reboot. Signed-off-by: SuvarnaMeenakshi <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…et#5122) NUM_ASIC environment variable was added so that it could be used by other utilities. This is not being used by any other utility or docker, hence removing the addition of NUM_ASIC environment variable. Also, the environment variable was added by adding the variable value to /etc/environ file. Upon each reboot, this file gets updated with the NUM_ASIC value but the existing value was not removed. This causes multiple lines getting appended in /etc/environ file upon each reboot. Signed-off-by: SuvarnaMeenakshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
NUM_ASIC environment variable was added so that it could be used by other utilities.
This is not being used by any other utility or docker, hence removing the addition of NUM_ASIC environment variable.
Also, the environment variable was added by adding the variable value to /etc/environ file.
Upon each reboot, this file gets updated with the NUM_ASIC value but the existing value was not removed.
This causes multiple lines getting appended in /etc/environ file upon each reboot.
- How I did it
Remove the addition of NUM_ASIC variable in /etc/environ file.
- How to verify it
Once image comes up, NUM_ASIC should not be present in environment variables in single asic and multi asic platforms.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)