-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relabel host #751
Merged
sgeannina
merged 38 commits into
ccp_shell_removal_branch_prod
from
relabel-host-pasthistory
Feb 20, 2024
Merged
Relabel host #751
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
02d7aa5
Relabel host value for api-server
6794859
Testing regex replacement
63a39fe
Testing
62a0d79
Testing
dae297c
Testing hash solution
931f909
Testing hash solution
1580461
Remove negative lookahead
b892a48
Hash testing
63b007d
Hash testing
1b0d825
Testing alias
5aec409
Testing
c6a6a63
Testing hash
eb49f3f
Testing alias
f75ca7f
Fix regex
2be85dd
Fix label
3213ab6
Revert labels
7ce635b
Testing
a9a62e4
Test diferent mod
5283a15
Testing hash with host only
2754b1e
Testing different mod
075fbe3
Drop tmp label
21e4af1
Add localhost for apiserver
efdfe03
Cleanup
a231e74
Only generate host alias for metrics with a host value
f6c03fa
Testing
6974bcb
Avoid adding host to the other metrics
e9fe8ef
Avoid generating hash for all metrics
c8d412f
Testing
22aa23f
Adjust rules
3236e80
Fix regex
ef7fe4b
Test regex
a0d7543
Adjust regex for kcm
486abe4
Remove unnecessary config
d25a874
revert
9d25608
Testing
dec9bcf
Cleanup
de53c49
Clean up
91952e6
Change branch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this filter doesn't really work as expected and it generates a hash for all metrics, the column is dropped at the end anyway so this behaviour is not visible. The replace logic has to check both [hostalias, host] as hashed alias will always have a value but host will be empty for metrics without this label.