Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action Deprecated #92

Open
jplummer01 opened this issue Feb 8, 2023 · 3 comments
Open

Github Action Deprecated #92

jplummer01 opened this issue Feb 8, 2023 · 3 comments
Assignees
Labels
Bug Something isn't working Needs Triage Needs Triage

Comments

@jplummer01
Copy link

Describe the bug or the issue that you are facing

image

Steps/Code to Reproduce

run the tf-gha-deploy-infra.yml github action

Expected Output

use of deprecated github feature

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Versions

latest MLOps-V2 Accelerator

Which platform are you using for deploying your infrastrucutre?

GitHub Actions (GitHub)

If you mentioned Others, please mention which platformm are you using?

No response

What are you using for deploying your infrastrucutre?

Terraform

Are you using Azure ML CLI v2 or Azure ML Python SDK v2

Azure ML CLI v2

Describe the example that you are trying to run?

following latest deployment guide

@jplummer01 jplummer01 added Bug Something isn't working Needs Triage Needs Triage labels Feb 8, 2023
@setuc
Copy link
Contributor

setuc commented Feb 22, 2023

@setuc is reviewing

@sdonohoo
Copy link
Contributor

I investigated this. The deprecated set-output calls are not explicitly in the MLOps SA code. They are in the javascript toolkit library used by the read_yaml action. This deprecation warning was recently reported for the toolkit itself (actions/toolkit#1336) though no update is available yet. Will monitor updates to the toolkit to mitigate the deprecation as well as investigate workarounds or new approach to read_yaml implementation in MLOps.

@sdonohoo sdonohoo assigned sdonohoo and unassigned setuc Feb 26, 2023
@djdean
Copy link
Collaborator

djdean commented Mar 10, 2023

This is apparently fixed in @actions/core v1.10.0, updated the NPM packages to the latest versions and created a PR. Unfortunately it looks like the warning will still be there but there is a fix in the actual code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Triage Needs Triage
Projects
None yet
Development

No branches or pull requests

4 participants