Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Mission Landing Zone can only be deployed to one region per subscription #760

Closed
LManning-Dev opened this issue Oct 14, 2022 · 0 comments · Fixed by #824
Closed

The Mission Landing Zone can only be deployed to one region per subscription #760

LManning-Dev opened this issue Oct 14, 2022 · 0 comments · Fixed by #824
Assignees
Labels
bicep Related to Bicep code bug Something isn't working

Comments

@LManning-Dev
Copy link
Contributor

Description

The deployment contains at least one module that has a static name: set-identity-sub-defender
This module gets stored as a deployment at the subscription level
When a 2nd instance of the MLZ is deployed to a DR site, an error occurs
The deployment 'set-identity-sub-defender' already exists in location

Note: If you deploy to the same region, no error is encountered. Possibly in this scenario the deployment item is able to be overwritten.

Steps to Reproduce

Steps to reproduce the behavior:

  1. deploy to eastus (any location)
  2. deploy to westus (any location other than step 1) to the same subscription(s) as 1

Expected behavior

Able to deploy a second MLZ region

Actual behavior

Error: The deployment 'set-identity-sub-defender' already exists in location 'eastus'
InvalidDeploymentLocation

Screenshots

Additional context

If you deploy to the same region, no error is encountered. Possibly in this scenario the deployment item is able to be overwritten.

Recommended Solution:
Change ALL deployment module names to end with the deploymentNameSuffix
(It looks like this was changed for many of them already: name: 'set-hub-sub-defender-${deploymentNameSuffix}')

I.E.
name: 'set-${spoke.name}-sub-defender'
name: 'set-${spoke.name}-sub-defender-${deploymentNameSuffix}'

List of modules that probably require the change
name: 'set-${spoke.name}-sub-defender'
name: 'azure-monitor-private-link'
name: 'azure-private-dns'

Thank you

Operating System:
Terraform Version:
Cloud (public, Azure Government, etc.):

@LManning-Dev LManning-Dev added the bug Something isn't working label Oct 14, 2022
@jamasten jamasten linked a pull request Jan 23, 2024 that will close this issue
@jamasten jamasten added the bicep Related to Bicep code label Jan 23, 2024
@jamasten jamasten self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bicep Related to Bicep code bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants