Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export src/terraform/mlz output by default #278

Closed
glennmusa opened this issue Jul 6, 2021 · 3 comments
Closed

Export src/terraform/mlz output by default #278

glennmusa opened this issue Jul 6, 2021 · 3 comments

Comments

@glennmusa
Copy link
Contributor

glennmusa commented Jul 6, 2021

Benefit/Result/Outcome
It would be helpful if the output from the main deployment was always available for reference.

Description
Today, the --write-output flag is an optional deployment setting. If I skipped this flag out of not-knowing it exists, when I go to deploy a Tier 3, the deployment will fail because the file could not be found.

The file is small and contains no secrets.

Acceptance Criteria

  • Write the output by default
  • Write the output with the environment name in the file name to keep consistency with how we generate .mlzconfig files and .tfvars files
  • Write the output as .tfvars instead of json so that the tier3/main.tf maintains compatibility with user-supplied .tfvars files.
  • Update the tier3/main.tf to remove the .value references
  • Write to output silently -- today output is tee'd to a file, use redirect instead so that it doesn't appear in the stdout during apply
@glennmusa
Copy link
Contributor Author

glennmusa commented Jul 6, 2021

+@sstjean

@glennmusa glennmusa changed the title Export Terraform Output by default Export src/terraform/mlz output by default Jul 6, 2021
@sstjean sstjean linked a pull request Jul 9, 2021 that will close this issue
6 tasks
@sstjean sstjean removed a link to a pull request Jul 9, 2021
6 tasks
@brooke-hamilton
Copy link
Contributor

@glennmusa do we still need this issue or is it OBE when we remove the scripting layer?

@brooke-hamilton
Copy link
Contributor

Closing because the scripting layer for Terraform will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants