From db2f96bc2aa560e7adfe355c50bf2b8f506d4c0f Mon Sep 17 00:00:00 2001
From: Marcelo Zambrana Villarroel <marcech.am@gmail.com>
Date: Tue, 24 Aug 2021 16:58:05 -0400
Subject: [PATCH] Updating some modules variables files (#363)

---
 .../modules/bastion/{output.tf => outputs.tf} |  0
 src/terraform/modules/bastion/variables.tf    |  3 ++-
 .../firewall/{output.tf => outputs.tf}        |  0
 src/terraform/modules/firewall/variables.tf   | 19 ++++++++++++++++++-
 4 files changed, 20 insertions(+), 2 deletions(-)
 rename src/terraform/modules/bastion/{output.tf => outputs.tf} (100%)
 rename src/terraform/modules/firewall/{output.tf => outputs.tf} (100%)

diff --git a/src/terraform/modules/bastion/output.tf b/src/terraform/modules/bastion/outputs.tf
similarity index 100%
rename from src/terraform/modules/bastion/output.tf
rename to src/terraform/modules/bastion/outputs.tf
diff --git a/src/terraform/modules/bastion/variables.tf b/src/terraform/modules/bastion/variables.tf
index f5034252a..21af31447 100644
--- a/src/terraform/modules/bastion/variables.tf
+++ b/src/terraform/modules/bastion/variables.tf
@@ -32,5 +32,6 @@ variable "ipconfig_name" {
 }
 
 variable "tags" {
-  type = map(string)
+  description = "A mapping of tags which should be assigned to the resource."
+  type        = map(string)
 }
diff --git a/src/terraform/modules/firewall/output.tf b/src/terraform/modules/firewall/outputs.tf
similarity index 100%
rename from src/terraform/modules/firewall/output.tf
rename to src/terraform/modules/firewall/outputs.tf
diff --git a/src/terraform/modules/firewall/variables.tf b/src/terraform/modules/firewall/variables.tf
index cbfc4ced5..796c78da6 100644
--- a/src/terraform/modules/firewall/variables.tf
+++ b/src/terraform/modules/firewall/variables.tf
@@ -3,66 +3,83 @@
 
 variable "sub_id" {
   description = "The subscription ID to deploy the Firewall into"
+  type        = string
+  sensitive   = true
 }
 
 variable "location" {
   description = "The location/region to keep all your network resources. To get the list of all locations with table format from azure cli, run 'az account list-locations -o table'"
+  type        = string
 }
 
 variable "resource_group_name" {
   description = "A container that holds related resources for an Azure solution"
+  type        = string
 }
 
 variable "vnet_name" {
   description = "The name of the Firewall virtual network"
+  type        = string
 }
 
 variable "vnet_address_space" {
   description = "The address space to be used for the Firewall virtual network"
+  type        = list(string)
 }
 
 variable "firewall_sku" {
   description = "The SKU for Azure Firewall"
+  type        = string
 }
 
 variable "client_address_space" {
   description = "The address space to be used for the Firewall subnets"
+  type        = string
 }
 
 variable "firewall_client_subnet_name" {
   description = "The name of the Firewall client traffic subnet"
+  type        = string
 }
 
 variable "firewall_management_subnet_name" {
   description = "The name of the Firewall management traffic subnet"
+  type        = string
 }
 
 variable "firewall_name" {
   description = "The name of the Firewall"
+  type        = string
 }
 
 variable "firewall_policy_name" {
   description = "The name of the firewall policy"
+  type        = string
 }
 
 variable "client_ipconfig_name" {
   description = "The name of the Firewall Client IP Configuration"
+  type        = string
 }
 
 variable "client_publicip_name" {
   description = "The name of the Firewall Client Public IP"
+  type        = string
 }
 
 variable "management_ipconfig_name" {
   description = "The name of the Firewall Management IP Configuration"
+  type        = string
 }
 
 variable "management_publicip_name" {
   description = "The name of the Firewall Management Public IP"
+  type        = string
 }
 
 variable "log_analytics_workspace_resource_id" {
   description = "The resource id of the Log Analytics Workspace"
+  type        = string
 }
 
 variable "tags" {
@@ -78,5 +95,5 @@ variable "tags" {
 variable "disable_snat_ip_range" {
   description = "The address space to be used to ensure that SNAT is disabled."
   default     = ["0.0.0.0/0"]
-  type        = list
+  type        = list(any)
 }