Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Resync triggers unreal Work metrics #867

Open
sschepens opened this issue Jun 26, 2024 · 1 comment
Open

[BUG] Resync triggers unreal Work metrics #867

sschepens opened this issue Jun 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sschepens
Copy link

Describe the bug

Resyncs trigger reprocessing of Work objects that haven't changed and this ends up generating unrealistic work_apply_time_seconds because this metric is based on a timestamp set on an annotation whenever the Work object was created/updated, so we end up with metrics that always hit the maximum bucket limits and are not really useful.

@sschepens sschepens added the bug Something isn't working label Jun 26, 2024
@ryanzhang-oss
Copy link
Contributor

@sschepens, thank you for the issue. You are right, that specific metrics will increase even when the work is not changed. I can think of a few ways to improve it. For example, we can only increase this if there is change. I think most of the functionality is there, I wonder if you want to give it try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants