Changed default for azcliversion. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-dedah
changed the title
vineetmimrot
reviewed
Nov 8, 2021
vineetmimrot
reviewed
Nov 8, 2021
vineetmimrot
reviewed
Nov 8, 2021
vineetmimrot
reviewed
Nov 9, 2021
anuragc617
approved these changes
Nov 10, 2021
t-dedah
added a commit
that referenced
this pull request
Nov 10, 2021
* Updated Readme for Azure CLI actions (#29) * Update README.md * Update README.md Co-authored-by: Usha N <[email protected]> * Add changes * Added add-label workflow (#41) * Added add-label workflow * Updated default label worlkflow for health dashboard * Reduced time * Added issue template for health dashboard (#42) * Added issue template for health dashboard * Added assignees * Add 'getting help' section to point customers to Azure CLI Repo for help (#50) Signed-off-by: James Casey <[email protected]> * Write Test Case For Azure cli Action (#48) * Create main.test.ts * Create ci-workflow.yml * Update main.ts * Update ci-workflow.yml * Update main.ts * Update ci-workflow.yml * Update ci-workflow.yml * Resolved multiple README issues (#51) * Resolved multiple issues * revert * Changed default for azcliversion. (#57) * Added restrictLatestToAgent * typo * required set to false * Changed default to agent az cli version * deleted lib files * Resolved comments * Add changes * Update package.json * Update package-lock.json * Upgrade version (#59) * Revert "Update package-lock.json" This reverts commit 5633362. * Revert "Update package.json" This reverts commit f4b36bb. * Upgrade version in packkage.json Co-authored-by: Zainudeen V K <[email protected]> Co-authored-by: Usha N <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: James Casey <[email protected]> Co-authored-by: PankajGovindRao <[email protected]>
Merged
jiasli
reviewed
Dec 5, 2023
|
|
||
| if(azcliversion == AZ_CLI_VERSION_DEFAULT_VALUE){ | ||
| const { stdout, stderr } = await cpExec('az version'); | ||
| if (!stderr) { |
There was a problem hiding this comment.
stderr should never be used as an indicator of failure. See Azure/azure-cli#18372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default value for azcliversion from
latesttoagentazcliversion. This will be protect the action from any breaking changes occurring due to mismatch between agent and latest cli versions.Permanent solution for this issue #56