Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: br/public:avm/res/network/application-gateway-web-application-firewall-policy:0.1.1 #3891

Closed
1 task done
gsuttie opened this issue Dec 5, 2024 · 7 comments · Fixed by #3901
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@gsuttie
Copy link

gsuttie commented Dec 5, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/network/application-gateway-web-application-firewall-policy

(Optional) Module Version

0.1.1

Description

"details":[{"code":"ApplicationGatewayWafPolicyJSChallengeCookieExpirationNotSupportedForAPIVersion","message":"Specified api-version 2022-11-01 does not meet the minimum required api-version 2023-11-01 for JSChallenge cookie expiration in Firewall Policy for resource

The polisy module refers to Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies@2022-11-01

Can this be updated to 2023-11-01?

(Optional) Correlation Id

No response

@gsuttie gsuttie added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 5, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Copy link

@gsuttie, thanks for submitting this issue for the avm/res/network/application-gateway-web-application-firewall-policy module!

Important

A member of the @Azure/avm-res-network-applicationgatewaywebapplicationfirewallpolicy-module-owners-bicep or @Azure/avm-res-network-applicationgatewaywebapplicationfirewallpolicy-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Dec 11, 2024
@AlexanderSehr
Copy link
Contributor

Hey @ilhaan,
Please triage the issue when you get the chance 💪

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Dec 19, 2024
@ilhaan
Copy link
Member

ilhaan commented Dec 20, 2024

@gsuttie do we know for sure that the new version will address this issue? Do you have any docs showing this?

Scratch that - looks like #3901 addresses this and has been merged.

@ilhaan ilhaan removed Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Dec 20, 2024
@ilhaan ilhaan closed this as completed in 88224f5 Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
3 participants