-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVM Module Issue]: DataFactory Private Endpoint issue #3878
Comments
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
@kevin-381ecc2e, thanks for submitting this issue for the Important A member of the @Azure/avm-res-datafactory-factory-module-owners-bicep or @Azure/avm-res-datafactory-factory-module-contributors-bicep team will review it soon! |
Hi @kevin-381ecc2e please can you explain more about "portal" I am not aware of this type. Also can you share a bit of the code you have implemented to give us a better idea of what the issue is? |
Sure, DataFactory consists of two private endpoints one for 'dataFactory' and one for 'portal'. However it seems when i create the portal one. It expects the groupId and memberId to be DataFactory. privateEndpoints: [
{
service: 'dataFactory'
subnetResourceId: '/subscriptions/0000000-0000000000-00000/resourceGroups/rg-datafactory/providers/Microsoft.Network/virtualNetworks/vnet-datafactory/subnets/subnet0'
customNetworkInterfaceName: 'nicDatafactory'
name: 'peDatafactory'
ipConfigurations: [
{
name: 'ipconfig1'
properties: {
groupId: 'dataFactory'
memberName: 'dataFactory'
privateIPAddress: '10.10.10.10'
}
}
]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: '/subscriptions/0000000-0000000000-00000/resourceGroups/rg-datafactory/providers/Microsoft.Network/privateDnsZones/privatelink.datafactory.azure.net'
}
]
}
}
{
subnetResourceId: '/subscriptions/0000000-0000000000-00000/resourceGroups/rg-datafactory/providers/Microsoft.Network/virtualNetworks/vnet-datafactory/subnets/subnet0'
customNetworkInterfaceName: 'nicPortal'
name: 'pePortal'
ipConfigurations: [
{
name: 'ipconfig1'
properties: {
groupId: 'portal'
memberName: 'portal'
privateIPAddress: '10.10.10.11'
}
}
]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: [
{
privateDnsZoneResourceId: '/subscriptions/0000000-0000000000-00000/resourceGroups/rg-datafactory/providers/Microsoft.Network/privateDnsZones/privatelink.adf.azure.net'
}
]
}
}
] from within the Azure portal i have these options. |
Hi @kevin-381ecc2e , thanks for the additional info! I believe your code will deploy successfully if you add: service: 'portal' as a property of the second private endpoint. If this property is not set, the module defaults to using Typically, we set a default service only in modules that support a single private endpoint type. In this case, we apparently overlooked the |
Thank you for your reply. It seems that adding 'service: portal' solves the issue. |
Check for previous/existing GitHub issues
Issue Type?
Bug
Module Name
avm/res/data-factory/factory
(Optional) Module Version
0.6.2'
Description
We're trying to provision DataFactories with Private Endpoints. However we're unable to provision a privateEndpoint with the groupId: 'portal'.
The template has a hardcoded groupId of 'dataFactory' under the privateLink configuration.
https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/data-factory/factory/main.bicep#L328.
I'm receiving the error:
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: