Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Support PostgreSQL 16 in PostgreSQL Flexible Server module #1310

Closed
1 task done
dslatkin opened this issue Mar 16, 2024 · 10 comments · Fixed by #3088
Closed
1 task done

[AVM Module Issue]: Support PostgreSQL 16 in PostgreSQL Flexible Server module #1310

dslatkin opened this issue Mar 16, 2024 · 10 comments · Fixed by #3088
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@dslatkin
Copy link

dslatkin commented Mar 16, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/db-for-postgre-sql/flexible-server

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

Right now the PostgreSQL Flexible Server module's version param only allows up to version 15, despite 16 being generally available in all Azure versions.

Also, thank you for picking up and maintaining this module! 🙏 😄 I saw it was orphaned until recently.

(Optional) Correlation Id

No response

@dslatkin dslatkin added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 16, 2024
@github-project-automation github-project-automation bot moved this to Todo in Bicep Mar 16, 2024
@github-actions github-actions bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 16, 2024
Copy link
Contributor

@dslatkin, thanks for submitting this issue for the avm/res/db-for-postgre-sql/flexible-server module!

A member of the @azure/avm-res-dbforpostgresql-flexibleserver-module-owners-bicep or @azure/avm-res-dbforpostgresql-flexibleserver-module-contributors-bicep team will review it soon!

@github-actions github-actions bot added the Class: Resource Module 📦 This is a resource module label Mar 16, 2024
Copy link
Contributor

This issue couldn't be assigend due to an internal error. @joaria, please make sure this issue is assigned to you and please provide an initial response as soon as possible, in accordance with the AVM Support statement.

@microsoft-github-policy-service microsoft-github-policy-service bot added Type: Feature Request ➕ New feature or request Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Mar 16, 2024
@AlexanderSehr
Copy link
Contributor

Hey @josearper, could you take a look an share your thoughts on the issue? :)

@josearper
Copy link
Contributor

Thanks @AlexanderSehr, I will be adding that in the future.

@AlexanderSehr
Copy link
Contributor

Great. Will remove the Triage tag then :)

@AlexanderSehr AlexanderSehr removed Needs: Triage 🔍 Maintainers need to triage still Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Mar 21, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Mar 22, 2024
@josearper
Copy link
Contributor

Looking into this one now.

@DanGiffen
Copy link

DanGiffen commented Aug 22, 2024

Hi @arnoldna,

2nd this one, also commented on the other issue #2203.

@DanGiffen
Copy link

Thanks @AlexanderSehr. Just for info, not sure if it's a timing or sync thing, but the versioning is not tying up. vs code intellisense only shows tags up to 0.1.6 as does the module index https://azure.github.io/Azure-Verified-Modules/indexes/bicep/bicep-resource-modules/ although this reports correctly https://mcr.microsoft.com/v2/bicep/avm/res/db-for-postgre-sql/flexible-server/tags/list. You can't see the tag list in the browser on github as they're too long but if I clone the repo I can list them. \bicep-registry-modules\avm\res\db-for-postgre-sql\flexible-server [main]> git tag -l "avm/res/db-for-postgre-sql/flexible-server/*". My deployment is working now btw, much appreciated 👍

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Aug 23, 2024

nfo, not sure if it's a timing or sync thin

Hey @DanGiffen,
'sadly' this is expected, yet only a caching issue. The VSCode extension caches the data und only updates it in a few cases (e.g. after restarting VSCode). I'm not entirely sure 'when' it happens, but the references will already resolve. It's really only the lists in VSCode that may not show it for a period of time.

@DanGiffen
Copy link

Ah ok yep, no worries cheers @AlexanderSehr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Archived in project
5 participants