From 0f10b10450df7657fac8e6e389e2f9a4e09d0f80 Mon Sep 17 00:00:00 2001 From: Alexander Sehr Date: Tue, 28 Nov 2023 19:27:46 +0100 Subject: [PATCH] fix: Hardcoded version check #669 (#675) ## Description Replaced hardcoded version check (using cognitive services) with `ModulePath` reference Closes: #669 ## Adding a new module - [ ] A proposal has been submitted and approved. - [ ] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. ## Updating an existing module - [x] This is a bug fix: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. - [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number. --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> --- .github/workflows/publish-module.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-module.yml b/.github/workflows/publish-module.yml index 57f3527160..2cd04c6786 100644 --- a/.github/workflows/publish-module.yml +++ b/.github/workflows/publish-module.yml @@ -104,7 +104,7 @@ jobs: done while true; do - TAGS=https://mcr.microsoft.com/v2/bicep/ai/cognitiveservices/tags/list + TAGS=https://mcr.microsoft.com/v2/bicep/$ModulePath/tags/list echo curl -sLo tags $TAGS curl -sLo tags $TAGS echo "Tags:"