Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update AKS OIDC Issuer link #799

Merged
merged 3 commits into from
Mar 20, 2023
Merged

docs: Update AKS OIDC Issuer link #799

merged 3 commits into from
Mar 20, 2023

Conversation

64J0
Copy link
Contributor

@64J0 64J0 commented Mar 20, 2023

Reason for Change:

When reading the documentation to start using this tool, I noticed that the AKS OIDC documentation link was incorrect. Indeed, the OIDC section apparently was taken away from the original page, and now we have a specific page for it, that is used in this PR.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:
Please, let me know if you'd like me to change something in the PR.

@64J0 64J0 requested a review from aramase as a code owner March 20, 2023 13:10
@64J0 64J0 changed the title Update AKS OIDC Issuer link Docs: Update AKS OIDC Issuer link Mar 20, 2023
@64J0 64J0 changed the title Docs: Update AKS OIDC Issuer link chore: Update AKS OIDC Issuer link Mar 20, 2023
@aramase aramase changed the title chore: Update AKS OIDC Issuer link docs: Update AKS OIDC Issuer link Mar 20, 2023
@aramase
Copy link
Member

aramase commented Mar 20, 2023

/azp run Azure Workload Identity CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @64J0! 🎉

@aramase aramase merged commit becf24c into Azure:main Mar 20, 2023
@64J0 64J0 deleted the 64J0-patch-2 branch March 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants