Bug: Duplicate key annotations under Deployment

[oistein]

Version of Azure Service Operator
Helm Chart v2.0.0-beta.1

Describe the bug
Duplicate pod spec annotations generated for the deployment.

To Reproduce
Steps to reproduce the behavior:

helm template --repo https://raw.githubusercontent.com/Azure/azure-service-operator/main/v2/charts azure-service-operator --version v2.0.0-beta.1 |grep "kind: Deployment" -A20
kind: Deployment
metadata:
  labels:
    app: azure-service-operator-v2
    control-plane: controller-manager
  name: azureserviceoperator-controller-manager
  namespace: azureserviceoperator-system
spec:
  replicas: 1
  selector:
    matchLabels:
      control-plane: controller-manager
  template:
    metadata:
      annotations:
        {}
      annotations:
        kubectl.kubernetes.io/default-logs-container: manager
      labels:
        aadpodidbinding: aso-manager-binding
        control-plane: controller-manager

Expected behavior
deployment.spec.template.metadata.annotations to appear once

This causes the install to fail when installing the helm release via flux. Due to Duplicate YAML Keys here.

[matthchr]

Thanks for the bug report @oistein. We'll look into fixing this shortly.

[matthchr]

This is fixed in the beta.2 chart:

$ helm template --repo https://raw.githubusercontent.com/Azure/azure-service-operator/main/v2/charts azure-service-operator --version v2.0.0-beta.2 |grep "kind: Deployment" -A20

kind: Deployment
metadata:
  labels:
    app: azure-service-operator-v2
    control-plane: controller-manager
  name: azureserviceoperator-controller-manager
  namespace: azureserviceoperator-system
spec:
  replicas: 1
  selector:
    matchLabels:
      control-plane: controller-manager
  template:
    metadata:
      annotations:
        kubectl.kubernetes.io/default-container: manager
      labels:
        aadpodidbinding: aso-manager-binding
        control-plane: controller-manager
    spec:
      containers:

[matthchr]

Closing this given the fix is in beta.2. Please let us know if you have any other issues with that chart.

[oistein]

Thanks for the quick fix @matthchr. Will give this another go.