Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check remote refs instead of local refs when applying/pushing changes #1645

Merged
1 commit merged into from
Jun 4, 2021
Merged

Check remote refs instead of local refs when applying/pushing changes #1645

1 commit merged into from
Jun 4, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Jun 1, 2021

With recent changes to use sparse checkout in our release steps, the assumption that all remote refs will be downloaded to the local git state no longer holds. This updates our git branch push script to check for pre-existing branches via git ls-remote instead, and additionally constrains the git fetch command to only fetch relevant refs.

@benbp benbp requested a review from a team as a code owner June 1, 2021 20:09
@benbp benbp self-assigned this Jun 1, 2021
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jun 1, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Jun 1, 2021

Template pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=922280&view=logs&j=3209e245-f6ba-5d50-799f-1562c2eae04f&t=37ce2dc7-5e9f-573b-8bc7-a6f98ce6968f

Right now that pipeline exercises the script against a full checkout, since the java repo reverted the sparse checkout. Testing for the latter scenario will gate Azure/azure-sdk-for-java#21912.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Jun 4, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 35596e9 into Azure:master Jun 4, 2021
@benbp benbp deleted the benbp/git-branch-push-remote branch June 4, 2021 23:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants