Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Automation - JS] Support SDK generation in CI pipeline for the services migrated from Swagger to TypeSpec #8057

Closed
Tracked by #8039
raych1 opened this issue Apr 10, 2024 · 2 comments · Fixed by #8826
Assignees

Comments

@raych1
Copy link
Member

raych1 commented Apr 10, 2024

If the migrated service has existing customized SDK code, the automation will keep them and report the error in the compiling step when the generated codes are not compatible with existing code.

This refers to the option 1 described in the linked epic.

option 1: keep the existing customized SDK code and generate the SDK code based on TypeSpec specs.
If the customized SDK code is not compatible with the new specs, the generation should fail in the build/compile step providing the comprehensive error message, such as "The SDK has customized SDK code and might not be compatible with the new specs, the service team may need to update the customized code or the new specs."

@MaryGao

@raych1
Copy link
Member Author

raych1 commented Jul 24, 2024

Synced with @wanlwanl and he will verify for both modular codeGen and RLC codeGen.

@lirenhe lirenhe moved this from Backlog to In Progress in API to SDK automation Aug 5, 2024
@wanlwanl
Copy link
Member

Code gen method:

  • autorest: codegen will clear code, so automation doesn't need to clear again
  • typespec: automation should clear package folder before code gen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants