Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK automation] SDK automation for TypeSpec PRs in the rest repo need to consider multiple products under a service directory #7603

Closed
catalinaperalta opened this issue Jan 31, 2024 · 1 comment
Assignees
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@catalinaperalta
Copy link
Member

catalinaperalta commented Jan 31, 2024

Services, like Health Insights, can provide multiple products under their general service definition, therefore we need to look for the tspconfig.yaml files for each product and run the SDK automation step for each one.

For example, given the following TypeSpec project structure:

- Health Insights/
  - main.tsp
  - tspconfig.yaml
  - OncoPhenoType/
    - client.tsp
    - tspconfig.yaml
    - <other product specific files>
  - RadiologyInsights/
    - client.tsp
    - tspconfig.yaml
    - <other product specific files>
  - TrialMatcher/
    - client.tsp
    - tspconfig.yaml 
    - <other product specific files>
  - ...etc

An automated SDK generation needs to be carried out for each of the Health Insights products listed under the main directory, in this scenario there would be an SDK automation run for each of the sub directories: OncoPhenoType, RadiologyInsights, TrialMatcher, etc

cc @weshaggard

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 31, 2024
@weshaggard
Copy link
Member

After talking with @raych1 I believe this scenario is supported the issue was related to another change that was breaking the automation. I'm going to close this but if that isn't the case please re-open with more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

3 participants