Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Runtime exception on breaking change check #6526

Open
chrissmiller opened this issue Jun 29, 2023 · 0 comments
Open

[Breaking Change] Runtime exception on breaking change check #6526

chrissmiller opened this issue Jun 29, 2023 · 0 comments
Assignees
@konrad-jamrozik
Labels
Breaking Changes Improvements to Breaking Changes tooling bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@chrissmiller
Copy link

A runtime exception occurs on breaking change check when RPs configure LRO options on a POST call to explicitly set final-state-via: operation-location. Operation-Location is the default value for dataplane polling on async POST calls, so it should be a supported value here to explicitly document the final-state-via functionality. Link to an impacted PR: Azure/azure-rest-api-specs#24291
@chrissmiller chrissmiller mentioned this issue Jun 29, 2023
Merged
3 tasks
@konrad-jamrozik konrad-jamrozik changed the title Runtime exception on breaking change check [Breaking Change] Runtime exception on breaking change check Jul 17, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jul 17, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Jul 17, 2023
@konrad-jamrozik konrad-jamrozik mentioned this issue Jul 17, 2023
Open
3 tasks
@konrad-jamrozik konrad-jamrozik transferred this issue from Azure/openapi-diff Jul 17, 2023
@konrad-jamrozik konrad-jamrozik added the Breaking Changes Improvements to Breaking Changes tooling label Jul 17, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 17, 2023
This was referenced Aug 16, 2023
Merged
Merged
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Aug 18, 2023
@konrad-jamrozik konrad-jamrozik added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 18, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Aug 18, 2023
@chrissmiller chrissmiller mentioned this issue Oct 2, 2023
Merged
3 tasks
@chrissmiller chrissmiller mentioned this issue Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Breaking Changes Improvements to Breaking Changes tooling bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🚢🎉
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konrad-jamrozik @chrissmiller