Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go - azadmin is failing consistently with a weird checkout error #6483

Closed
scbedd opened this issue Jul 10, 2023 · 5 comments
Closed

go - azadmin is failing consistently with a weird checkout error #6483

scbedd opened this issue Jul 10, 2023 · 5 comments
Assignees
Labels
Asset-Sync Any issues relating to moving test assets out of repos.

Comments

@scbedd
Copy link
Member

scbedd commented Jul 10, 2023

See this failing pipeline for an example failing build.

Need to jump on this priority as it is blocking a release.

@scbedd scbedd added the Asset-Sync Any issues relating to moving test assets out of repos. label Jul 10, 2023
@scbedd scbedd self-assigned this Jul 10, 2023
@scbedd scbedd changed the title go - azkeys is failing consistently with a weird checkout error go - azadmin is failing consistently with a weird checkout error Jul 10, 2023
@benbp
Copy link
Member

benbp commented Jul 10, 2023

@scbedd looks like the failure is related to coverage, not checkout? Or maybe I'm looking at a different pipeline result. For coverage the values get set here: https://github.com/Azure/azure-sdk-for-go/blob/main/eng/config.json#L102

@scbedd
Copy link
Member Author

scbedd commented Jul 10, 2023

@benbp I hadn't dug in yet, @gracewilcox was just over asking. The build failure that she had me looking at included a checkout failure. I really haven't dug in at all yet though, just created a tracking item and went back to what I was doing. Will dig later today.

@gracewilcox
Copy link
Member

@scbedd looks like the failure is related to coverage, not checkout? Or maybe I'm looking at a different pipeline result. For coverage the values get set here: https://github.com/Azure/azure-sdk-for-go/blob/main/eng/config.json#L102

It's citing a code coverage issue since TestRoleDefinitions and TestGetSettings is failing, therefore it's not meeting code coverage minimum. It says that "Recording ID was not returned by the response."

@scbedd
Copy link
Member Author

scbedd commented Jul 11, 2023

Alright, so I had a chat with grace, and we think we understand why we are seeing this Admin/ResetSanitizer only now.

  1. It's not a restore conflict. That is addressed by my test pr here which just removes any possibility of race-condition during restore.
  2. After we fix the restore, we actually see a new error. This new error is because the azadmin package is actually multiple packages. As each package finishes or starts, they fire session-level Admin/Reset at the proxy. Because there are multiple packages, we fire multiple Admin/Reset requests, and those may or may not stomp on currently active playback sessions.

This multiple packages being handled by one proxy while they each assume they're the only one running in the session is the reason why we only see this TYPE of failure for azblobs, azfile, or azadmin. These are the only package within packages we have for go!

I will resolve the weird checkout error in #6484, but that will just reveal this other reset error.

I will close this issue as completed with the other PR, and work with the go team to make each package invoke it's own test-proxy for the go team.

@scbedd
Copy link
Member Author

scbedd commented Jul 11, 2023

We have set an override within the go repo to the previous version of the proxy. We'll unpin while we fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset-Sync Any issues relating to moving test assets out of repos.
Projects
Archived in project
Development

No branches or pull requests

3 participants