Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move request methods to pipeline #294

Closed
heaths opened this issue Jun 12, 2021 · 5 comments
Closed

Move request methods to pipeline #294

heaths opened this issue Jun 12, 2021 · 5 comments
Labels
CodeGen Issues that relate to code generation

Comments

@heaths
Copy link
Member

heaths commented Jun 12, 2021

Rather than expose the underlying HttpClient, we should move request methods to the pipeline like in our other SDKs. We have helper methods for creating paged results, handling different error cases, etc. This also make it possible to abstract the pipeline from the protocol and handle, potentially, AMQP.
@heaths heaths mentioned this issue Jun 12, 2021
Merged
@yoshuawuyts
Copy link
Contributor

Can we merge this issue into the #290 tracking issue?

@heaths
Copy link
Member Author

heaths commented Sep 1, 2021

That's all rather specific to Cosmos. This is specifically about refactoring the pipeline now so that we're not depending on reqwest's Request (or wherever it comes from - I forget off hand).

@cataggar cataggar self-assigned this Oct 14, 2021
@cataggar
Copy link
Member

I want to update the services to do this.

@cataggar cataggar added the CodeGen Issues that relate to code generation label Oct 14, 2021
@cataggar cataggar mentioned this issue Oct 19, 2021
Closed
@cataggar cataggar added this to the Services v0.1 milestone Oct 22, 2021
@cataggar cataggar removed this from the services 0.1.0 milestone Nov 28, 2021
@cataggar
Copy link
Member

Services have been updated in #527.

@cataggar cataggar removed their assignment Jan 12, 2022
@cataggar
Copy link
Member

cataggar commented Jul 5, 2022

Closing this in favor of #802.

@cataggar cataggar closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heaths @yoshuawuyts @cataggar