Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ws connection expiryTime change to unblock 1.8.0 #30701

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Revert ws connection expiryTime change to unblock 1.8.0 #30701

merged 2 commits into from
Jun 9, 2023

Conversation

luigiw
Copy link
Contributor

@luigiw luigiw commented Jun 9, 2023 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@luigiw luigiw enabled auto-merge (squash) June 9, 2023 07:49
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@luigiw luigiw merged commit d4887c5 into Azure:main Jun 9, 2023
luigiw added a commit that referenced this pull request Jun 9, 2023
@luigiw
Revert ws connection expiryTime change to unblock 1.8.0 (#30701)
f059075 
* Revert "expose workspace connection secret expiryTime in sdk (#30170)"

This reverts commit 3600711.

* revert changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singankit singankit singankit approved these changes

@wenjie1070116 wenjie1070116 wenjie1070116 approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nemanjarajic nemanjarajic Awaiting requested review from nemanjarajic

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

Assignees
No one assigned
Labels
Machine Learning ML-WorkspaceConnections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigiw @azure-sdk @wenjie1070116 @singankit