Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Add public_exponent option to create_key #18024

Merged
merged 4 commits into from
Apr 16, 2021
Merged

[Key Vault] Add public_exponent option to create_key #18024

merged 4 commits into from
Apr 16, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 13, 2021

Resolves #18016.

This also tweaks pipeline test configuration, since local testing has shown that we need a longer delay before assigning crypto roles (otherwise we get an error). platform-matrix.json has been changed to more closely resemble JS's because HSMs aren't being properly deployed for pipeline tests (see example here).

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Apr 13, 2021
@mccoyp mccoyp requested review from chlowell and schaabs as code owners April 13, 2021 23:44
@mccoyp
Copy link
Member Author

mccoyp commented Apr 14, 2021

@benbp Does this platform-matrix.json and tests.yml setup look like it will correctly enable HSM deployment?

@mccoyp mccoyp requested a review from benbp April 14, 2021 01:09
@chlowell
Copy link
Member

Will public_exponent be in the stable 7.2?

@mccoyp
Copy link
Member Author

mccoyp commented Apr 14, 2021

.NET still has this checked in so I would think it's staying, but we won't know for sure until the stable 7.2 swagger is finished up (expected by 4/23)

chlowell
chlowell reviewed Apr 14, 2021
View reviewed changes
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/_client.py
@@ -58,6 +58,7 @@ async def create_key(self, name: str, key_type: "Union[str, KeyType]", **kwargs:
:keyword curve: Elliptic curve name. Applies only to elliptic curve keys. Defaults to the NIST P-256
elliptic curve. To create an elliptic curve key, consider using :func:`create_ec_key` instead.
:paramtype curve: ~azure.keyvault.keys.KeyCurveName or str
:keyword int public_exponent: The RSA public exponent to use. Applies only to RSA keys created in a Managed HSM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this on create_rsa_key as well, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should! I remember making that update in a dream last night, but I evidently didn't remember to translate that into the material world

@mccoyp
Copy link
Member Author

mccoyp commented Apr 15, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mccoyp
Copy link
Member Author

mccoyp commented Apr 15, 2021

/check-enforcer reset

@mccoyp
Copy link
Member Author

mccoyp commented Apr 15, 2021

/check-enforcer evaluate

@mccoyp
Copy link
Member Author

mccoyp commented Apr 16, 2021

/azp run python - keyvault - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp requested a review from chlowell April 16, 2021 17:26
@mccoyp mccoyp merged commit a5d0e97 into Azure:master Apr 16, 2021
@mccoyp mccoyp deleted the public-exp branch April 16, 2021 21:22
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 22, 2022
@zjpjack @matthchr
CodeGen from PR 18324 in Azure/azure-rest-api-specs
8b21e13 
Review request for Microsoft.ContainerService to add version 2022-02-01 (Azure#18324)

* Adds base for updating Microsoft.ContainerService from version stable/2022-01-01 to version 2022-02-01

* Updates readme

* Updates API version in new specs and examples

* Update readmes for the 2022-02-01 dev branch of container service (Azure#17887)

* update readme

* remove useless -only tags

* Fix violated rule R2026 for 2022-02-01 managedCluster swagger (Azure#18024)

* fix allof

* add missing type

* GA alias minor version (Azure#18038)

* GA alias minor version

* polish more details on kubernetesVersion and currentKubernetesVersion

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-02-01/managedClusters.json

minor revision

Co-authored-by: Matthew Christopher <[email protected]>

Co-authored-by: Matthew Christopher <[email protected]>

* add missing type object (Azure#18115)

* Revert "GA alias minor version (Azure#18038)" (Azure#18291)

This reverts commit 3a99cda3cb48e05c74923f5467c0737014322b0f.

* Align modifications of several common definitions with 2022-02-02-preview for container service 2022-02-01 (Azure#18216)

* sync modification

* fix ref

Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@schaabs schaabs Awaiting requested review from schaabs

@benbp benbp Awaiting requested review from benbp

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@scbedd scbedd Awaiting requested review from scbedd

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Key Vault] Add public_exponent option to create_key
2 participants
@mccoyp @chlowell