CertificateCredential requires either certificate_path or certificate_data #17852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
approved these changes
Apr 6, 2021
| @@ -72,6 +72,8 @@ def get_client_credential(certificate_path, password=None, certificate_data=None | |||
| """Load a certificate from a filesystem path or bytes, return it as a dict suitable for msal.ClientApplication""" | |||
|
|
|||
| if certificate_path: | |||
| if certificate_data: | |||
| raise ValueError('Please specify either "certificate_path" or "certificate_data"') | |||
There was a problem hiding this comment.
The language technically already implies this, but I think it might help to be explicit about only accepting one or the other. I wouldn't die on this hill though
Suggested change
| raise ValueError('Please specify either "certificate_path" or "certificate_data"') | |
| raise ValueError('Please specify exactly one of either "certificate_path" or "certificate_data"') |
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Apr 9, 2021
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Apr 13, 2021
benbp
pushed a commit
to benbp/azure-sdk-for-python
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but giving it both is a ValueError.