Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container Registry] ACR list_repositories pageable #17714
[Container Registry] ACR list_repositories pageable #17714
Changes from 102 commits
5e854e6
eb5eb54
785564d
561128f
beba7fc
9c7acd5
8c03d93
5a16d1c
b628b6f
b70ce96
2bedabe
fa6f78e
514d03b
4063d4d
c280520
4a9cc33
5e2270c
b2ba50f
fb4189f
7108594
4dd3c8c
4533cce
2b3bb91
34b094e
a4d0258
2058b4a
70d8524
9da7eee
eea6749
875b422
648102b
7a6bd87
f82ed35
6ba90be
b0922ba
82c5d3c
103db71
9a26fcf
8ec00fd
7e4333e
5d12869
5bd806b
b56c29e
5151b8d
cb9611b
cf02b85
544c9b7
1f1eb4c
643e937
dfdbe82
d68285b
93ad7c4
c1f5198
166661e
b14a81b
06fb6a5
fc88483
da18b29
f3dc746
aef65bd
6304e37
17a1a07
7465c81
7ed5107
340d128
76b8ca0
ac6352b
ce532bc
6be366a
d8e3a4d
5d97e0b
451a186
23caed4
f4799e5
35df077
f95947d
0941cec
4714e61
94c3488
822d407
db97e0f
52a746f
89ab5d0
a728852
f2a5da9
31fc9ff
db4040f
0be38fe
3e6b8c2
4b11a77
47e395b
0cabe74
c2eaab3
de15691
a30712d
af91b4a
c36ed08
9dda7f8
a8adc8b
0fcb0b8
64c8fc0
23f55d6
0a2c1eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, lot of code, sorry you had to copy that. I think the code looks reasonable, my only question is if you want to move this code to the helper section. Not a big deal, just think keeping the main container registry client page as bare as possible is neater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, but then I need to pass in the client too and this was a bit simpler.