[Communication]: Fixed github issue for phone numbers and sms readme files #17681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsundaralingam
requested review from
beltr0n,
sacheu,
ankitarorabit and
jbeauregardb
lsundaralingam
requested review from
memontic-ms,
turalf and
a team
as code owners
ghost
added
the
This was
linked to
issues
Mar 30, 2021
beltr0n
approved these changes
Mar 30, 2021
lsundaralingam
changed the title
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 17, 2022
Initial commit for new version and new child resource type extended l… (Azure#17681) * Initial commit for new version and new child resource type extended location New version: 2021-08-31-preview New child resource type: resource sync rule * Fix lint check errors and cross version breaking changes validation issues * Try to fix Cross-Version Breaking Changes * Revert changes to previous stable version * Remove "x-ms-identifiers" definition which will cause golang sdk generation error * Address review comments, revert unnecessary changes * Try fix breaking error * Revert changes which fix lint error but will cause cross version breaking changes * Fix lintdiff validation issue and also add back two updates for this version only * Update descriptions of properties of resource sync rules. * Update description of the resource sync rules API * Update description of resource sync rules selector property * Update description of matchExpressions * Update description of targetResourceGroup * Fix a required LintDiff check Adding "x-ms-identifiers": [] to matchExpressionsList * Add title to readme.typescript.md * Update specification/extendedlocation/resource-manager/readme.typescript.md * Revert cross version breacking changes Co-authored-by: Wei Dong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: