Resource Group Preparer Logging #17573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
Mar 25, 2021
weshaggard
reviewed
Mar 25, 2021
weshaggard
reviewed
Mar 25, 2021
| expiry = datetime.datetime.utcnow() + self.delete_after_tag_timedelta | ||
| parameters["tags"] = {"DeleteAfter": expiry.replace(microsecond=0).isoformat()} | ||
| expiry = datetime.datetime.utcnow() + self.delete_after_tag_timedelta | ||
| parameters["tags"] = {"DeleteAfter": expiry.replace(microsecond=0).isoformat()} |
There was a problem hiding this comment.
Should we add these to the try block below with the other tags?
There was a problem hiding this comment.
This one doesn't need to be, the others do because when running locally those environment variables wont be set.
There was a problem hiding this comment.
Ok so the there is no try get env variable in python to allow for these to be empty if they aren't found?
weshaggard
approved these changes
Mar 25, 2021
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.