Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify autorest in pipeline #16667

Merged
54 commits merged into from
Apr 26, 2021
Merged

Verify autorest in pipeline #16667

54 commits merged into from
Apr 26, 2021

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft self-assigned this Feb 11, 2021
@seankane-msft seankane-msft marked this pull request as ready for review March 10, 2021 19:35
@seankane-msft
Copy link
Member Author

/azp run python - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft
Copy link
Member Author

/azp run python - appconfiguration

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@scbedd scbedd mentioned this pull request Apr 14, 2021
Closed
@seankane-msft seankane-msft requested a review from scbedd April 14, 2021 18:01
@seankane-msft
Copy link
Member Author

/check-enforcer reset

scbedd
scbedd approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this will fail more than a few. If you're ok with dealing with the fallout, I won't block on this. all the requested code changes are done :)

@seankane-msft
Copy link
Member Author

I have a feeling this will fail more than a few. If you're ok with dealing with the fallout, I won't block on this. all the requested code changes are done :)

I need to revisit this @scbedd and make sure it's only target appconfig for now. Then I will merge. I don't want to disrupt anyone other myself 😃

@ghost
Copy link

ghost commented Apr 26, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ec58f5b into master Apr 26, 2021
@ghost ghost deleted the feat/regenerate-autorest branch April 26, 2021 19:53
@seankane-msft seankane-msft mentioned this pull request Jul 6, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp left review comments

@scbedd scbedd scbedd approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

Assignees

@seankane-msft seankane-msft

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seankane-msft @benbp @scbedd