Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding live code-coverage for just python39 #15709

Merged
merged 7 commits into from
Dec 15, 2020
Merged

adding live code-coverage for just python39 #15709

merged 7 commits into from
Dec 15, 2020

Conversation

seankane-msft
Copy link
Member

Breaking PR #15577 into two PRs, the latter will focus on the report generation. This PR is just for enabling code coverage

@seankane-msft seankane-msft self-assigned this Dec 8, 2020
@seankane-msft
Copy link
Member Author

/azp run python - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

scbedd
scbedd previously approved these changes Dec 8, 2020
View reviewed changes
@scbedd
Copy link
Member

scbedd commented Dec 8, 2020

@seankane-msft Can you do me a favor and do a quick search for any other tests.yml that invoke a custom matrix of platforms? Extend those with coverageArg as well.

@seankane-msft
Copy link
Member Author

/azp run python - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft seankane-msft requested a review from scbedd December 9, 2020 17:34
@seankane-msft
Copy link
Member Author

Addresses #15132

lmazuel
lmazuel approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the intent, need a engsys approval before merging. Thanks!

scbedd
scbedd reviewed Dec 15, 2020
View reviewed changes
sdk/schemaregistry/tests.yml Outdated
PythonVersion: '3.8'
CoverageArg: '--disablecov'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want one to remain right?

scbedd
scbedd reviewed Dec 15, 2020
View reviewed changes
sdk/monitor/tests.yml Outdated Show resolved Hide resolved
scbedd
scbedd reviewed Dec 15, 2020
View reviewed changes
sdk/eventhub/tests.yml Outdated Show resolved Hide resolved
seankane-msft and others added 3 commits December 15, 2020 16:45
scbedd
scbedd approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept suggestions, otherwise g2g.

@seankane-msft seankane-msft merged commit 80f68d3 into Azure:master Dec 15, 2020
@seankane-msft seankane-msft deleted the add-live-code-cov branch December 15, 2020 22:35
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Aug 26, 2021
@Nilambari @abhi7860
@Syair @Wistlie @wangxu724 @guptas14 @akshaysngupta @litchiyangMSFT @nagula-ritvika @davelasc @b564518128 @tinawu6 @irrogozh
CodeGen from PR 15709 in Azure/azure-rest-api-specs
717111a 
Mitryakh/network march (Azure#15709)

* Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (Azure#14462)

* Adding Bastion Host Configuration Features (Azure#14442)

Co-authored-by: Abhishek Shah <[email protected]>

* Add PL ASG (Azure#14620)

* Add PL ASG

* Prettier

* [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (Azure#14662)

* Ipconfigurations swagger

* Ran prettier check

* fixing conflicting files

* fixing lint

* Fixing linter diff

* Lint diff

* resolving comments

* fixing conflict

* Fioxing

* running prettier

* Fixing linter comment

Co-authored-by: Shane Baden <[email protected]>

* Add missing properties of ServiceEndpointPolicy (Azure#14948)

* Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response

* Add missing 'contextualServiceEndpointPolicies'

* fix bug

* fix type

* Add missing properties to ServiceEndpointPolicy

* Revert "fix type"

This reverts commit 3a49beb66d9bbb288fa0d3baaeaf5aaf2bbc6ee9.

* Revert "fix bug"

This reverts commit a4fff4ae925b01ed0cfb07b1594fb95e2c6649c7.

* Revert "Add missing 'contextualServiceEndpointPolicies'"

This reverts commit ccf19167abc61b90bce6b5204dc3b2a64fdf4ca4.

* Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response"

This reverts commit e532cc1118241a74902e4362c32c25c11a764933.

Co-authored-by: Xu Wang <[email protected]>

* add new service tag details api (Azure#14958)

* add new service tag details api

* prettier check fixes

* fixing lint issue, additional properties issue

* Add Load distribution policy and global configuration to AppGW (Azure#14790)

* add Load distribution policy and global configuration to Application Gateway resource

* prettify

* remove provisioning state

* add public ssh key to network virtual appliance (Azure#14988)

* Changes needed for BgpEndpoint (Azure#14800)

* changes needed for BgpEndpoint

* prettier check

* model validation fix

* fix description

* update again

* Multi QoS support for DSCP configuration (Azure#15120)

* Updating the DSCP jsons to reflect the  multi-qos support

* Adding support to multi-qos

* adding the type object to NrpQos

* fixing the prettier
removing my update to the settings

* fixing the missing type object error. seeing if this also fixes the additional attributes exception

* fixing the prettier exception

* almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo

* copying what I did with my other objects

* names didn't match with what I have in NRP's src

* forgot to update the examples with the updates in the specification. updating it

* fixing the merge exceptions

* Add SQL Setting to Firewall Policy (Azure#15110)

* Add SQL Setting to Firewall Policy

* fix lint check except for object type

* resolve linter error

* network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (Azure#15318)

* fix: change target to an array and add subresource properties

* fix target examples

* Support to update tags for BastionHost resource (Azure#15446)

* Initial commit

* Validation fixes

* Update bastionHost.json

Co-authored-by: Abhishek Shah <[email protected]>

* Azure FW - Explicit Proxy feature swagger change (Azure#15017)

* explicit proxy swagger change

* prettier check fix

* lint check

* prettier fix

* revert unnecessary file change

* Add kind to virtual hub (Azure#15562)

* Adding customnetworkinterfacename attribute to Private Endpoint (Azure#15574)

Co-authored-by: Shane Baden <[email protected]>

* Added 3 new properties to InboundNatRule resource (Azure#15611)

* Added the missins properties to fix the change breaking update (Azure#15732)

Co-authored-by: Nilambari <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: Yang Shi <[email protected]>
Co-authored-by: Shane Baden <[email protected]>
Co-authored-by: Shane Baden <[email protected]>
Co-authored-by: Xu Wang <[email protected]>
Co-authored-by: Xu Wang <[email protected]>
Co-authored-by: guptas14 <[email protected]>
Co-authored-by: Akshay Gupta <[email protected]>
Co-authored-by: litchiyangMSFT <[email protected]>
Co-authored-by: Ritvika Reddy Nagula <[email protected]>
Co-authored-by: David Velasco <[email protected]>
Co-authored-by: Jiejiong Wu <[email protected]>
Co-authored-by: tinawu6 <[email protected]>
Co-authored-by: irrogozh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@lmazuel lmazuel lmazuel approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees

@seankane-msft seankane-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seankane-msft @scbedd @lmazuel