Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes from arch board review meeting for python #5499

Closed
YijunXieMS opened this issue May 28, 2019 · 1 comment
Closed

Misc changes from arch board review meeting for python #5499

YijunXieMS opened this issue May 28, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@YijunXieMS
Copy link
Contributor

• Unify the constructor parameters across languages
• Remove partition_count from the result of get_properties()
• Remove the from_* except for from_connection_string.  Use a different credentials object
• Auto_reconnect should be default=true (this should probably be hidden as well) - ditto for keep_alive_interval - it should be hidden
• In receiver, consumer_group is required - it should be optional (with a default value of $default)
• Consider removing open() in the receiver - just manage the link in .receive() - if not removing open(), then add it to other languages.
• Implement __repr() and __str() for the events that are received
• Support custom decoders on events that we can pass into json decoder
• Remove the receiver.subscribe() for preview - discuss with Johan about design before inclusion
• Rename partition to partition_id (to sync with other languages)

Consider hiding queue_messages() / send_pending_messages() - it's covered by send()

@YijunXieMS YijunXieMS added this to the Sprint 153 milestone May 28, 2019
@YijunXieMS YijunXieMS added Client This issue points to a problem in the data-plane of the library. Event Hubs labels May 28, 2019
@YijunXieMS
Copy link
Contributor Author

All done except the the following two deferred items.

  • repr()
  • "Support custom decoders on events that we can pass into json decoder"

Two separate issues were created for them.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants