Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking changes tracker] Update suppression mechanism to support more complex suppression scenarios #35988

Closed
catalinaperalta opened this issue Jun 8, 2024 · 3 comments · Fixed by #37196
Assignees

Comments

@catalinaperalta
Copy link
Member

  • We might want to suppress changes reported at the function or property level for all models or operations.
  • We may want to add suppressions across libraries.

Example:
Mgmt plane libraries migrating to dpg will need to widely suppress changes between msrest and the new dpg design on all models.

@catalinaperalta
Copy link
Member Author

Some scenarios to consider:

  • Suppress a change on a parameter in a whole library
  • Suppress a change on a method in a whole library
  • Suppress a change across multiple libraries. i.e. suppress the removed *ListResult model across all mgmt specs.

Should we be able to suppress a change with a regex to match model names following that pattern?

@catalinaperalta
Copy link
Member Author

Do we also need an exception mechanism for mass suppressions? i.e. suppress changes reported throughout all of the mgmt libs except for one.

@msyyc
Copy link
Member

msyyc commented Jun 20, 2024

Do we also need an exception mechanism for mass suppressions? i.e. suppress changes reported throughout all of the mgmt libs except for one.

As MGMT SDK owner, I hope we could have the exception mechanism.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants