Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document supportability of tenant_id in all docstring of azure-identity implementation #23139

Closed
lmazuel opened this issue Feb 18, 2022 · 1 comment
Assignees
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@lmazuel
Copy link
Member

lmazuel commented Feb 18, 2022

Some credentials instance will support tenant_id, and some won't (like ManagedIdentity). For clarity for users, the docstring needs to explicitly state if the tenant_id will be ignored, or is an effective parameter

All credit for @mccoyp to have raised the issue

@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. Azure.Identity blocking-release Blocks release labels Feb 18, 2022
@mccoyp
Copy link
Member

mccoyp commented Feb 18, 2022

We should also explicitly state how we do or don't honor claims, and any other arguments specified in the TokenCredential protocol, for future reference

@lmazuel lmazuel added this to the [2022] March milestone Feb 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants