Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-mgmt-sql: LICENSE missing from PyPi #20183

Closed
major opened this issue Aug 9, 2021 · 3 comments · Fixed by #20193
Closed

azure-mgmt-sql: LICENSE missing from PyPi #20183

major opened this issue Aug 9, 2021 · 3 comments · Fixed by #20193
Assignees
@msyyc
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@major
Copy link
Contributor

major commented Aug 9, 2021

  • Package Name: azure-mgmt-sql
  • Package Version: 3.0.1
  • Operating System: Linux
  • Python Version: 3.9.6

Describe the bug
The LICENSE file is missing from azure-mgmt-sql in PyPi.

Additional context
I am making a PR for this now.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 9, 2021
@major major mentioned this issue Aug 9, 2021
Closed
@swathipil swathipil added bug This issue requires a change to an existing behavior in the product in order to be resolved. Mgmt This issue is related to a management-plane library. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 9, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 9, 2021
@lmazuel
Copy link
Member

lmazuel commented Aug 9, 2021

Hi @major

Most of packages are auto-generated from a template system, so I won't accept your PRs since they will be overwritten by the template anyway. Can you PR the template maybe? This would simplify your work.

https://github.com/Azure/azure-sdk-for-python/tree/main/tools/azure-sdk-tools/packaging_tools/templates

Thanks!

@major
Copy link
Contributor Author

major commented Aug 9, 2021

@lmazuel Thanks for the tip. I saw that code there but I wasn't sure how or when it was used. I'll try doing a PR there instead.

@major major mentioned this issue Aug 9, 2021
Merged
@major
Copy link
Contributor Author

major commented Aug 9, 2021

@lmazuel I'm new to the templating setup. Could you take a look at #20193 and let me know if this is the right way to do it? Thanks! 🤗

This was referenced Aug 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
scbedd added a commit that referenced this issue Oct 14, 2021
@major @scbedd @xiangyan99
[packaging] Include license in PyPi packages (#20193)
9ac7834 
* [packaging] Include license in PyPi packages

The MIT license requires that a copy of the license is distributed with
the software. Add the license to the template and also add it to the
manifest file.

Fixes: #20183

Signed-off-by: Major Hayden <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Xiang Yan <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Aug 25, 2022
CodeGen from PR 20183 in Azure/azure-rest-api-specs
381c70b 
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-08-01 (Azure#20183)

* Adds base for updating Microsoft.RecoveryServices from version stable/2022-05-01 to version 2022-08-01

* Updates readme

* Updates API version in new specs and examples
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@msyyc msyyc

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[packaging] Include license in PyPi packages
{azure-mgmt-sql} Add LICENSE to PyPi pkg
4 participants
@major @lmazuel @msyyc @swathipil