Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend minimum dependency checks to dev_requirements #19051

Closed
scbedd opened this issue Jun 2, 2021 · 2 comments
Closed

Extend minimum dependency checks to dev_requirements #19051

scbedd opened this issue Jun 2, 2021 · 2 comments
Assignees
@scbedd
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Jun 2, 2021 •
edited
Loading

This issue was raised by a conflict that was temporarily resolved in this pr.

opentelemetry-sdk in our dev requirements installs at version 1.3.0
opentelemetry-api in our setup.py installs at version 1.0.0 during minimum dependency versioning. (as this really is the minimum required version of this package).

However, due to compatibility reasons within those two packages, opentelemetry-sdk==1.3.0 requires opentelemetry-api>=1.3.0. The lack of the latter due to minimum testing causes a break.

Need a resolver to take care of this non-sense for us.
@scbedd scbedd added the EngSys This issue is impacting the engineering system. label Jun 2, 2021
@scbedd
Copy link
Member Author

scbedd commented Mar 4, 2022

Related to #23146

@scbedd scbedd added Central-EngSys This issue is owned by the Engineering System team. and removed EngSys This issue is impacting the engineering system. labels Mar 4, 2022
@scbedd scbedd self-assigned this Mar 4, 2022
@scbedd
Copy link
Member Author

scbedd commented Mar 15, 2023

Closing for address in #23146

@scbedd scbedd closed this as completed Mar 15, 2023
@github-project-automation github-project-automation bot moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scbedd scbedd

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scbedd